Skip to content

Introduce log levels with slog #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Introduce log levels with slog #65

Copilot wants to merge 3 commits into from

Conversation

Copy link

Copilot AI commented Nov 12, 2025 •
edited
Loading

Replaces logrus with Go's standard library log/slog for structured logging with configurable log levels. Debug logs are now enabled via DEBUG=1 environment variable.

Implementation

  • New logging abstraction (pkg/logging/)

    • SlogLogger: Wraps log/slog, implements Logger interface
    • LogrusAdapter: Maintains compatibility for existing logrus usage
    • Logger interface: Implementation-agnostic (no longer tied to *logrus.Entry)

  • Main initialization (main.go)

    • Added initLogger() to configure log level from DEBUG env var
    • Sets slog.LevelDebug when DEBUG=1, otherwise slog.LevelInfo

  • Updated dependencies

    • ClientConfig.Logger now uses logging.Logger interface
    • Removed hardcoded logrus level manipulation in pkg/metrics
    • All tests updated to use new interface

Usage

# Enable debug logging
DEBUG=1 ./model-runner

# Docker
docker run -e DEBUG=1 docker/model-runner:latest

Log output format:

time=2025-11-12T15:55:44.435Z level=INFO msg="Successfully initialized store" component=model-manager
time=2025-11-12T15:55:44.435Z level=DEBUG msg="Loading model from cache" model=llama-3

Structured logging still supported:

log.WithFields(map[string]interface{}{
    "component": "backend",
    "model": "llama-3",
}).Debug("Model loaded")
Original prompt

This section details on the original issue you should resolve

<issue_title>Introduce log levels with slog</issue_title>
<issue_description>There is a library in stdlib that is ideal for this, --debug should print all the debug-level logs:

https://pkg.go.dev/log/slog</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 12, 2025 15:56
@ericcurtin
Implement slog-based logging with DEBUG environment variable support
a125952 
- Add slog-based logger wrapper (SlogLogger) that implements the logging.Logger interface
- Create LogrusAdapter to maintain compatibility with existing logrus code
- Replace logrus with slog in main.go, controlled by DEBUG environment variable
- Update logging.Logger interface to be implementation-agnostic
- Update all test files to use the new logging interface
- Maintain backward compatibility with existing code using logrus

Co-authored-by: ericcurtin <[email protected]>
@ericcurtin
Add logging tests and documentation
99697ac 
- Add comprehensive tests for SlogLogger (debug levels, fields, errors, fatal handling)
- Add logging.md documentation explaining how to use DEBUG mode
- All tests pass successfully

Co-authored-by: ericcurtin <[email protected]>
Copilot AI changed the title [WIP] Introduce log levels using slog library Introduce log levels with slog Nov 12, 2025
Copilot AI requested a review from ericcurtin November 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericcurtin ericcurtin Awaiting requested review from ericcurtin

Assignees

@ericcurtin ericcurtin

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce log levels with slog

2 participants

@ericcurtin